[Koha-bugs] [Bug 1386] New: "maxlength" in template causes broken Issuing Rules

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1386

           Summary: "maxlength" in template causes broken Issuing Rules
           Product: Koha
           Version: branch 2.2
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Installation
        AssignedTo: mjr at ttllp.co.uk
        ReportedBy: dswhite42 at spambob.com
         QAContact: koha-bugs at nongnu.org


On the Intranet "Issuing Rules" page, one might put in a "fine" value of 1,7,7
(i.e. $1.00 fine after the 7th day, every 7 days).  However in the MySQL
"issuingrules" table, the "fine" column has a datatype of DECIMAL(28,6).  So
the fine value is stored as "1.000000"

Next time the Issuing Rules page is loaded, the value of the "fine" form field
will be prefilled with "1.000000,7,7".  However, the form field has a hardcoded
maxlength value of 10, so what the librarian sees in the form is actually
"1.000000,7".  If the form is submitted, that value will be passed to the
database, and the last item in the form field will be lost, causing
"firstremind" to be set to NULL in the "issuingtable" table.

Workaround: Set the maxlength of the fields to be longer than 10 characters.  I
made these changes for myself in
{KOHA}/intranet/htdocs/intranet-tmpl/npl/en/parameters/issuingrules.tmpl and
{KOHA}/intranet/htdocs/intranet-tmpl/default/en/parameters/issuingrules.tmpl ,
but they would need to be changed in other templates as well.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.