[Koha-bugs] [Bug 2000] New: separation of issuing & fines rules breaks defaults propagation

bugzilla-daemon at pippin.metavore.com bugzilla-daemon at pippin.metavore.com
Mon Apr 7 20:54:03 CEST 2008


http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2000

           Summary: separation of issuing & fines rules breaks defaults
                    propagation
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: blocker
          Priority: P3
         Component: Circulation
        AssignedTo: chris at bigballofwax.co.nz
        ReportedBy: rch at liblime.com
         QAContact: koha-bugs at lists.koha.org


I've submitted a patch for Circulation.pm that reproduces GetLoanLength's
issuingrule determination in a new fcn: GetIssuingRule().
This is intended to replace Overdues.pm's GetIssuingRules(), 
which ignores both defaults and branches.
However, this reveals a bug:
By separating the interfaces for Issuing and Fines, the following condition
arises:
(1) set any branch, any borrower category, and just default fines for itemypes.
(2) set Issuing rule for specific branch, specific categorycode.

This creates an entry with null fine that overrides the intended default
behavior for the fines interface.

>From the state of current code, I don't imagine that any currently live/testing
3.0 installs are actually using the Fines Rules interface outside of Sanop , so
I suggest a simple fix:

If fines are used, require that smart-rules.pl  is the issuingrules interface.
Else, allow use of issuingrules.pl.
and, remove finesrules.pl 

Thoughts ?




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.



More information about the Koha-bugs mailing list