[Koha-bugs] [Bug 2565] New: CalcFine mistached in fines.pl, fines questionable in 3.0

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2565

           Summary: CalcFine mistached in fines.pl, fines questionable in
                    3.0
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Command-line Utilities
        AssignedTo: jmf at liblime.com
        ReportedBy: joe.atzberger at liblime.com
         QAContact: koha-bugs at lists.koha.org


In the release version of fines.pl, there is a mismatch in the number of
returned values expected from CalcFine:

  my ($amount,$type,$printout,$daycounttotal,$daycount)= CalcFine($data->[$i],
$borrower->{'categorycode'}, $branchcode,undef,undef, $datedue ,$today);

In my patch, changed to:

  my ($amount,$type,$daycounttotal,$daycount)= CalcFine($data->[$i],
$borrower->{'categorycode'}, $branchcode,undef,undef, $datedue, $today);

Because CalcFine returns only 4 things:

    return ($amount, $data->{'chargename'}, $days_minus_grace, $daystocharge);


I also added "FIXME: chargename is NEVER populated anywhere" for the obvious
reason.

Note this appears to be a mismatch in the vestigial fines-ll.pl also!




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.