[Koha-bugs] [Bug 1908] Reference to preference HomeOrHoldingBranch is misspelled and also tries to compare the literal string 'homebranch' or 'holdingbranc

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1908


chris at bigballofwax.co.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Priority|P3                          |PATCH-Sent




------- Comment #1 from chris at bigballofwax.co.nz  2008-02-27 11:36 -------
It was a system preference added while I was at liblime, its used in
conjunction with Independent Branches.

if ( C4::Context->preference("IndependantBranches") ) {
        my $userenv = C4::Context->userenv;
        if ( ($userenv) && ( $userenv->{flags} != 1 ) ) {
            $issuingimpossible{NOTSAMEBRANCH} = 1
              if ( $item->{C4::Context->preference("HomeOrHoldingbranch")} ne
$userenv->{branch} );
        }
    }
To check whether the holdingbranch or homebranch controlled if an item could be
issued. IE if a book had its homebranch set to another library, but was trying
to be checked out at another library, whether that was allowed. If home branch
was set, it will check what is in the items homebranch against the issuing
branch. If holdingbranch checks that again.

The typo crept in here
http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=a4e0051daab548e7b3baf269dd2f15c1118b28e9

When I was adding the syspref as someone had assumed as they didnt know what it
did to just delete it.
It looks better with the B so ill change the code to match




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.