[Koha-bugs] [Bug 1910] New: Errors in Overdues.pm that break fines2.pl

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1910

           Summary: Errors in Overdues.pm that break fines2.pl
           Product: Koha
           Version: rel_3_0
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Command-line Utilities
        AssignedTo: jmf at liblime.com
        ReportedBy: dswhite42 at yahoo.com
         QAContact: koha-bugs at nongnu.org


Chris Nighswonger has helpfully pointed out a bug in C4/Overdues.pm that breaks
the functionality of fines2.pl, and I have found another.

1) "C4::Context" is misspelled at one place as "C4::context"

2) The call to &logaction() in Overdues.pm passes in the parameter
C4::Context->userenv->{'number'}.  This causes the error message "Can't use
string ("0") as a HASH ref while "strict refs" in use at
/usr/share/koha/lib/C4/Overdues.pm line 511."  

I don't know enough about the code to understand what
C4::Context->userenv->{'number'} is, but I'm guessing that perhaps it gets set
in the ordinary web-environment usage of Koha, but not during the running of a
cronjob?  At any case, I simply replaced that parameter with "", and it fixed
the problem for me. 

Patch attached.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.