[Koha-bugs] [Bug 1753] New: use of 'new CGI' in C4/Rports.pm

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1753

           Summary: use of 'new CGI' in C4/Rports.pm
           Product: Koha
           Version: HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Reports
        AssignedTo: chris.cormack at liblime.com
        ReportedBy: galen.charlton at liblime.com
         QAContact: koha-bugs at nongnu.org


I have a reservation about the following commit:

http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commitdiff;h=ab8104f99f4d16afce10d41206d69e6094ab8cd7

By adding 'my $cgi = new CGI' to C4/Reports.pm, the CGI input will be parsed
before a script that includes C4::Reports has a chance to run.  This could
potentially mean that POSTDATA and/or file uploads may not be available to the
calling script.  In addition, any command-line scripts that may use C4::Reports
will not behave as expected.

Can this be refactored so that the theme and language are passed by the calling
script?




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.