[Koha-bugs] [Bug 1953] remove possible SQL injection attacks

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1953





------- Comment #10 from Andrew.moore at liblime.com  2008-07-30 11:49 -------
I appear to have written a test that doesn't always work right. I'll get to
this soon:

# KohaTest::Items::GetItemsForInventory->basic_usage
ok 1076 - we have a call number to search for: 8eCsPId
ok 1077 - We were able to call GetItemsForInventory with our call number isa
ARRAY
ok 1078 - ...and we found only one item
not ok 1079 - ...and the item we found has the right itemnumber

#   Failed test '...and the item we found has the right itemnumber'
#   at lib/KohaTest/Items/GetItemsForInventory.pm line 80.
#   (in KohaTest::Items::GetItemsForInventory->basic_usage)
#          got: '47'
#     expected: '43'
# $items = [
#            {
#              'itemnumber' => '47',
#              'datelastseen' => '07/30/2008',
#              'biblionumber' => '43',
#              'itemcallnumber' => '8eCsPId',
#              'author' => 'Twain, Mark',
#              'title' => 'The Adventures of Huckleberry Finn Test 1',
#              'barcode' => '123456782gaAXGS'
#            }
#          ];
# 
# KohaTest::Items::GetItemsForInventory->date_last_seen
ok 1080 - we have a call number to search for: 8eCsPId
ok 1081 - We were able to call GetItemsForInventory with our call number isa
ARRAY
ok 1082 - ...and we found only one item
not ok 1083 - ...and the item we found has the right itemnumber

#   Failed test '...and the item we found has the right itemnumber'
#   at lib/KohaTest/Items/GetItemsForInventory.pm line 106.
#   (in KohaTest::Items::GetItemsForInventory->date_last_seen)
#          got: '47'
#     expected: '43'
ok 1084 - We were able to call GetItemsForInventory with our call number isa
ARRAY
ok 1085 - ...and we found no items
# 
# KohaTest::Items::GetItemsForInventory->methods
ok 1086 - C4::Items->can(...)
# 
# KohaTest::Items::GetItemsForInventory->missing_parameters
not ok 1087 - missing parameters # TODO GetItemsForInventory should fail when
missing required parameters

#   Failed (TODO) test 'missing parameters'
#   at lib/KohaTest/Items/GetItemsForInventory.pm line 63.
#   (in KohaTest::Items::GetItemsForInventory->missing_parameters)
# $items = [];
ok 1088 - truncated tables
ok 1089 - created bookseller: 1




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.