[Koha-bugs] [Bug 2154] New: Patron image not uploaded when use translated interface

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2154

           Summary: Patron image not uploaded when use translated interface
           Product: Koha
           Version: rel_3_0
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Tools
        AssignedTo: galen.charlton at liblime.com
        ReportedBy: bgkriegel at gmail.com
         QAContact: koha-bugs at lists.koha.org


On tools/picture-upload.pl the line
my $op                  = $input->param('op');
catch the option selected to Upload or not a patron image. Then it is compared
against the string "Upload".

But on the related template (picture-upload.tmpl) the strings associated with
"op" parameter can be translated (they are in the .po file). 
In Spanish we have
<input type="submit" name="op" value="Subir" class="submit">
<input type="submit" name="op" value="Cancelar" class="submit">

This clearly do not work. I fixed it myself touching the .pl, but perhaps it is
a better idea to use a bit of javascript to change the values of the submit
buttons (onsubmit) to the english ones (and block its translation).

I wonder if there are other cases like this on the code.






# Agregado para corregir traduccion de opciones
$op = ($op == "Subir" ) ? "Upload" : "Cancel" ;




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.