[Koha-bugs] [Bug 2182] Overdue Items list dates in European format

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2182





------- Comment #6 from rch at liblime.com  2008-05-30 14:02 -------

accountlines should refer to a PK in one of several possible tables, though
primarily either issues/old_issues or items, since the fine may be for a
damaged/lost item or for an issue, or could be a checkout charge or a reserve
fee.  Unfortunately we don't have pks on some of these tables.  I would prefer
to hold off on 'fixing' this, and instead redesign fines management so that
charges and payments can be reliably associated with the relevant issues,
reserves or items.  

fines-ll.pl, btw, uses us dates format, also hardcoded.




(In reply to comment #5)
> This bug is caused by the fines scripts (fines2.pl, fines-ll.pl, and
> fines-sanop.pl), each of which gets the due date, converts it to the European
> date format without using C4::Dates and the the dateformat syspref, and stores
> it (via UpdateFines) in accountlines.description.
> 
> A fix would be straightforward - using C4::Dates to format the date before
> storing it.  However, there is one fly in the ointment - UpdateFines does a
> query on accountlines to determine whether an existing overdue fine exists, and
> that query includes the text of the due date from accountlines.description!!!
> That means that the naive correction to the bug can break updates of overdue
> fines that exist prior to the fix, since "05/09/08" would not match "09/05/08".
> :(
> 
> A better fix will have to include doing something better than relying on
> specially formatted strings in accountlines.description to match an overdue
> fine to the loan that inspired it.  What this fix entails (it may involve
> adding an explicit link between accountlines and isues) is not specified yet.
> 
> Reassigning this bug to Andy since he's looking at the relevant fine jobs soon.
> 




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.