[Koha-bugs] [Bug 2000] separation of issuing & fines rules breaks defaults propagation

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2000





------- Comment #4 from rch at liblime.com  2008-05-30 22:31 -------

Actually, this reveals a further issue with Paul's recent patch:
http://lists.koha.org/pipermail/koha-patches/2008-May/000585.html
Here we are using '*' in the branch and categorycode columns of the
issuingrules table to mean 'default', but it means 'total' for itemtypes.
But that is meaningless for fines, so a single entry in the issuingrules table
then means 'total' for maxissueqty, but 'default' for fines columns.

Thus, relabelling 'Any' to 'Total' in smartrules.pl for itemtype 
(as I suggest in
http://lists.koha.org/pipermail/koha-patches/2008-May/000619.html )
Will not work.
I think we need to add a 'default' for itemtype, which should be '*' in
issuingrules table (i.e., don't push Paul's patch), and if we want to enforce a
'total', we need to test against another character, say '~' or '+' for a rule
indicating total (only applicable to itemtype).
I think it would be easier to code that than to write the documentation to
explain the differences in issuingrules.pl and smartrules.pl and how 'Any'
means one thing for maxissueqty but another thing for fines settings.

If that is done, then I think it's sufficient to simply say 'use smartrules if
you charge fines, if not, you can use issuingrules.pl', so there's no need to
test for fines use. 



(In reply to comment #3)
> The question is how to determine that a system is using fines or not. 
> Hopefully we don't need a syspref, and can just take the full-population of any
> fines line as proof enough?
> 




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.