[Koha-bugs] [Bug 2631] New: useDaysMode values confused

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2631

           Summary: useDaysMode values confused
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: System Administration
        AssignedTo: paul.poulain at free.fr
        ReportedBy: joe.atzberger at liblime.com
         QAContact: koha-bugs at lists.koha.org


I'm confused by SysPref "useDaysMode".  The values come from the SQL:

VALUES('useDaysMode','Calendar','Choose the method for calculating due date:
select Calendar to use the holidays module, and Days to ignore the holidays
module','Calendar|Days|Datedue','Choice');


3 values, but only 2 descriptions:
~ "Datedue" is only used in C4::Calendar::addDate
~ "Days" is only used in C4::Circulation::CalcDateDue

Neither is used in the other.  That's sorta funny, since you would expect
CalcDateDue to worry more about "DateDue".  

The value "Calendar" isn't referenced anywhere!  The French translated SQL only
has "Calendar" and "Days".  

This suggests there should only be two values.  One is "literal", and the other
isn't.  We call the latter "Calendar" although it doesn't seem to matter what
we call it.  The "literal" option is the one we need a consistent name for. 
Looks like "Days" is the original value.  We should stick to that without a
really good reason to modulate.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.