[Koha-bugs] [Bug 3142] New: standardize how OPAC and staff determine requestability

bugzilla-daemon at liblime.com bugzilla-daemon at liblime.com
Sun Apr 19 15:21:13 CEST 2009


http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3142

           Summary: standardize how OPAC and staff determine requestability
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Hold requests
        AssignedTo: galen.charlton at liblime.com
        ReportedBy: galen.charlton at liblime.com
   Estimated Hours: 0.0


The OPAC and bib details and MARC display have varying code to determine
whether an item should be displayed as available to place a hold request. 
These should be consolidated into a function:

catalogue/detail.pl:

$norequests = 0 unless ( ( $item->{'notforloan'} > 0 ) || (
$item->{'itemnotforloan'} > 0 ) );

catalogue/detailprint.pl:

$norequests = 0 unless $itm->{'notforloan'};

catalogue/MARCdetail.pl:

$norequests = 0 if $subf[$i][1] ==0 and $tagslib->{ $field->tag() }->{
$subf[$i][0] }->{kohafield} eq 'items.notforloan'
    ;

NOTE: There is another problem here - this is grabbing item data directly from
the MARC record when it should be using GetItems().

opac/opac-detail.pl:

126      $norequests = 0
127        if ( (not $itm->{'wthdrawn'} )
128          && (not $itm->{'itemlost'} )
129          && ($itm->{'itemnotforloan'}<0 || not $itm->{'itemnotforloan'} )
130          && (not $itemtypes->{$itm->{'itype'}}->{notforloan} )
131          && ($itm->{'itemnumber'} ) );

opac/opac-detailprint.pl:

$norequests = 0 unless $itm->{'notforloan'};

Note that there can be legitimate differences between how the requestability is
calculated between OPAC and staff.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the Koha-bugs mailing list