[Koha-bugs] [Bug 3697] SIP item information response doesn't include due date

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3697





--- Comment #5 from frederic at tamil.fr  2009-12-01 10:12:25 ---
> I think that MsgType.pm is handling the date format for those date fields
> completely wrong. In sub handle_item_information around line 1126 it uses the
> timestamp format which looks like "20091201    100633". This is normally the
> transaction date format used at the beginning of most SIP2 messages. Fields
> like due_date, recall_date or hold_pickup_date are usually in the YYYY-MM-DD
> format. 

'are usuallly in the YYYY-MM-DD format' doesn't mean the same thing as MUST BE.
What about an hourly loan? It seems that now MsgType.pm expect a epoch
formatted date and then it transforms it in timestamp format which is specified
in Sip/Constants.pm file. In my opinion, the ILS layer should return what the
SIP layer expects. So ILS/Items.pm should be modified.

> 
>         if (($i = $item->due_date) != 0) {
> -           $resp .= add_field(FID_DUE_DATE, Sip::timestamp($i));
> +           $resp .= add_field(FID_DUE_DATE, $i);
>         }
>         if (($i = $item->recall_date) != 0) {
> -           $resp .= add_field(FID_RECALL_DATE, Sip::timestamp($i));
> +           $resp .= add_field(FID_RECALL_DATE, $i);
>         }
>         if (($i = $item->hold_pickup_date) != 0) {
> -           $resp .= add_field(FID_HOLD_PICKUP_DATE, Sip::timestamp($i));
> +           $resp .= add_field(FID_HOLD_PICKUP_DATE, $i);

'recall_date' and 'hold_pickup_date' seem not to be returned at all...


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.