[Koha-bugs] [Bug 1807] ':' character blocks search ; search () give odd results

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1807


Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |gmcharlt at gmail.com
         AssignedTo|jmf at liblime.com             |chris at bigballofwax.co.nz




--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz>  2009-12-12 08:09:56 ---
\ works ok now

() is still a problem, its caused by

if ( $query =~ /(\(|\))/ ) {                                                    
        return (                                                                
            undef,              $query, $simple_query, $query_cgi,              
            $query,             $limit, $limit_cgi,    $limit_desc,             
            $stopwords_removed, 'ccl'                                           
        );                                                                      
    }    

Which causes us to bail out before $query_cgi has anything assigned to it, and
only the first operand used as the search.
I think that not trying to handle nested queries is a valid stance for 3.2.0 
That would mean that you can search on phrases containing ().

I have sent a patch for that, and will send a patch fixing the : error too.

Search.pm is slated for a total rewrite for 3.4.0, but I think that having it
working (and losing the nested queries) is ok for 3.2.0 .. galen?


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.