[Koha-bugs] [Bug 3536] Checked In item requiring transfer does not consistently trigger transfer prompt

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3536


Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
         AssignedTo|gmcharlt at gmail.com          |chris at bigballofwax.co.nz




--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz>  2009-12-23 01:11:49 ---
Further investigation 
We have discovered the culprit.

my $hbr = $item->{C4::Context->preference("HomeOrHoldingBranch")} || ''; 

So if you have HoldingBranch set .. then it won't attempt a transfer back to
the items homebranch, but to its holdingbranch instead. Which I don't think is
the intended behaviour. This overrides the syspref to do automatic transfer to
homebranch. I think $hbr should always get the value of the items homebranch.


This plus the other error (the fact a transfer is only done if an item is
returned) cause the behaviour.

I can send a patch to fix, but I'd like some agreement that checking the items
homebranch is the right thing to do when working out if a transfer is needed.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.