[Koha-bugs] [Bug 2940] New: Subsequent pages of private shelves fail to display

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2940

           Summary: Subsequent pages of private shelves fail to display
           Product: Koha
           Version: HEAD
          Platform: PC
               URL: http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-
                    shelves.pl?display=privateshelves?viewshelf=120&itemoff=
                    2
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Virtual Shelves
        AssignedTo: joe.atzberger at liblime.com
        ReportedBy: joe.atzberger at liblime.com
         QAContact: koha-bugs at lists.koha.org


The script uses primitive URL hacks to try to insert into the query string,
resulting in links to addresses like:

http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-shelves.pl?display=privateshelves?viewshelf=120&itemoff=2

Note that "?" appears twice.  This is because lines 295-296 of
C4/VirtualShelves/Page.pm are:

$url .= "?display=" . $query->param('display') if $query->param('display');
$url .= "?viewshelf=" . $query->param('viewshelf') if
$query->param('viewshelf');

The second conditional doesn't check if the first was already done.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.