[Koha-bugs] [Bug 3195] No entry in branchtransfers table causes improper holds processing.

bugzilla-daemon at liblime.com bugzilla-daemon at liblime.com
Thu May 7 04:54:15 CEST 2009


http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3195





--- Comment #1 from Ryan Higgins <rch at liblime.com>  2009-05-07 02:54:15 ---

More here:  after fixing the bad function call, we see that the sub that is
responsible for initiating the transfer GetOtherReserves :

sub GetOtherReserves {
    my ($itemnumber) = @_;
    my $messages;
    my $nextreservinfo;
    my ( $restype, $checkreserves ) = CheckReserves($itemnumber);
    if ($checkreserves and $restype ne "Waiting" ) {


However, CheckReserves() returns 'Waiting' if reserves.priority==0.
And we have a zero priority after a branch transfer is initiated, but
reserves.found is still NULL.

A quick git blame :
257a439d C4/Reserves.pm  (Nahuel ANGELINETTI 2009-03-10 15:28:17 +0100 366)    
if ($checkreserves and $restype ne "Waiting" ) {

commit message :

    (bug #3025) multiple check-in of a multiple times reserved item go wrong

    This patch check that an item is not "Waiting" before do something in
GetOtherReserves(because is the item is waiting, we don't need to do
something).

So this patch should be reverted and another fix for bug 3025 needs to be
found.

(Also apply patch to fix the call to ModItemTransfer)


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the Koha-bugs mailing list