[Koha-bugs] [Bug 3785] New: New Install, no maxreserves setting, OPAC holds fail

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3785

           Summary: New Install, no maxreserves setting, OPAC holds fail
           Product: Koha
           Version: rel_3_0
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Hold requests
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: jwagner at ptfs.com
   Estimated Hours: 0.0
 Change sponsored?: ---


On a new git install, if the site has not set any value in the maxreserves
syspref, trying to place a hold through the OPAC results in a blank screen. 
There is no visible error message, but the error log says:

opac-reserve.pl: Argument "" isn't numeric in numeric ge (>=) at
/home/servername/kohaclone/opac/opac-reserve.pl line 265.

When I look at line 265 in opac-reserve.pl, here's the code block:

if ( scalar(@reserves) >= $MAXIMUM_NUMBER_OF_RESERVES ) {
    $template->param( message => 1 );
    $noreserves = 1;
    $template->param( too_many_reserves => scalar(@reserves));
}

Setting a numeric value in the syspref made holds work OK, but the code needs
to be fixed so that it accounts for a null or empty entry.  How best to do
that?

I'm not sure what section of code to check, to see if staff-side holds has the
same problem.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.