[Koha-bugs] [Bug 3754] Language detection doesn't take really care of syspref

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3754


Ricardo Dias Marques <ricmarques at spamcop.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ricmarques at spamcop.net




--- Comment #6 from Ricardo Dias Marques <ricmarques at spamcop.net>  2009-11-17 15:38:05 ---

Nahuel Angelinneti has submitted a patch that solves this problem and that was
committed for the 3.0.x branch of Koha. The patch is available here:

---------------------------------------- 
(bug #3754) fix language choose 
http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=df25509e8c500c0e91b9f2343ebca1c7c98238cf 

author  Nahuel ANGELINETTI <nahuel.angelinetti at biblibre.com> 
        Tue, 3 Nov 2009 15:30:22 +0000 (16:30 +0100) 
committer Henri-Damien LAURENT <henridamien.laurent at biblibre.com> 
        Tue, 3 Nov 2009 15:47:46 +0000 (16:47 +0100) 
commit  df25509e8c500c0e91b9f2343ebca1c7c98238cf 
---------------------------------------- 

This patch solved a problem that I was having, in the Intranet (Staff)
interface in a Koha 3.0.4 setup (UNIMARC and NoZebra installation, running in a
SLES 11 virtual machine - SUSE Linux Enterprise Server 11). That installation
had "Português" (Portuguese, "pt-PT") and also "Português (Brasil)"
(Brazilian Portuguese, "pt-BR") template folders. After I logged in to the
staff client, I got the *very weird* screenshot (in Mozilla Firefox 3.5.5, in
Windows XP Professional) that's available at:

http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1248

The languages set in Firefox (under "Tools", "Options", "Content" tab,
"Languages" section) were these (in the following order):
- Portuguese [pt] 
- English/United States [en-us] 
- French [fr] 
- English [en] 


The problem was correctly traced by Chris Cormack that pointed that, for
"pt-BR", there's no "includes" directory under:
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/pt-BR


However, my System Preferences that are related to language have the following
values (none of them mentions pt-BR):

mysql> select variable, value from systempreferences where variable LIKE
'%lang%';
+----------------------+----------+
| variable             | value    |
+----------------------+----------+
| language             | pt-PT,en |
| opaclanguages        | pt-PT,en |
| opaclanguagesdisplay | 1        |
+----------------------+----------+
3 rows in set (0.00 sec)


The weird look of the screenshot went away when applying Nahuel's patch. Thanks
Nahuel!  :) 


HOWEVER, I was unable to switch between "Português" (Portuguese) and
"English". I created a follow-up patch to Nahuel's (that "builds" on his patch)
and that solved the problem of being unable to switch. I sent the patch to the
"Koha Patches" mailing list and the patch is available at:

[Koha-patches] [PATCH] Bug 3754: Follow-up patch 
http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1252

So, I would like to ask you to also apply ("commit") my patch to the 3.0.x
branch, so that it gets included for the 3.0.5 release. I don't have a git
setup for the "master" branch but I suspect that these problems also happen for
that one, and so the two patches should also be applied to that branch (as two
patches or as a single patch).

On a related note, could you also commit the following patch (also for 3.0.5):

[Koha-patches] [PATCH] Fix for Bug 3730 - Wrong ISO 639-2 Language Code for
Portuguese in database 
http://lists.koha.org/pipermail/koha-patches/2009-October/004766.html


Thanks and congratulations for the work already done!  :)


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.