[Koha-bugs] [Bug 3704] New: SIP Checkin of not checked out item returns error without additional reason

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3704

           Summary: SIP Checkin of not checked out item returns error
                    without additional reason
           Product: Koha
           Version: rel_3_0
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SIP2
        AssignedTo: joe.atzberger at liblime.com
        ReportedBy: patrick.langer at easycheck.org
   Estimated Hours: 0.0
 Change sponsored?: ---


Checking in a not checked out item returns an error (which is correct) without
giving a reason for the failure as screen_msg (aka AF field in SIP2) is empty.

Checkin in koha SIP is generally quite sparse when it comes to error handling
and reasons for the failure of the checkin. Most times no screen_msg is filled
which makes it hard for the self service terminal to display an understandable
reason to the patron for the failure.

In this case I suggest to insert in SIP::ILS Checkin around row 183 right after
$circ->ok($item && $item->{patron});

if (!defined($item->{patron})) {
  $circ->screen_msg("Item  not checked out");
} else {
[rest of the transaction part]
}


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.