[Koha-bugs] [Bug 3614] New: Error in C4/Biblio.pm

[Colin Campbell]

On 09/14/2009 12:35 PM, bugzilla-daemon at kohaorg.ec2.liblime.com wrote:

> The statement:
>
> $ind1 = " " if !defined($ind2) or $ind2 eq "";
>
> should be changed to:
>
> $ind1 = " " if !defined($ind1) or $ind1 eq "";
>

Well spotted.
The typo is invited by the verbosity of the construct
if ($ind1) {
will check both definedness and that its not an empty string.

worth mentioning because its a common idiom in the codebase
Colin


-- 
Colin Campbell
Software Engineer, PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 208 366 1295 (phone)
+44 (0) 7759 633626  (mobile)
colin.campbell at ptfs-europe.com
skype: colin_campbell2

http://www.ptfs-europe.com