[Koha-bugs] [Bug 4394] opaccolorstylesheet syspref won't allow an external URL

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4394


J. David Bavousett <dbavousett at ptfs.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dbavousett at ptfs.com




--- Comment #2 from J. David Bavousett <dbavousett at ptfs.com>  2010-04-21 14:33:29 ---
There are a couple of problems with this patch as-is:

a) As HDL pointed out in the Patches list, this would immediately break
existing values of the syspref, unless the user remembered to tweak the
existing syspref as soon as they deployed it. 

b) Sites that are using themes/language variants wouldn't be able to use
different stylesheets in the variations; this may or may not be problematic. 
It would be a better solution, again concurring with HDL, to check and see if
the syspref contains http:// or https:// (or slashes, to pick off a local file
that isn't in the standard places) and if so, pass it through untouched,
otherwise to insert the theme/lang/css value as in the existing code.  Might
need to back up a step or two in the code, and do that in
C4::Context::preference, then make darn sure that this same change is applied
everywhere relevant.  (That would add to this proposed patch, not replace it.)


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.