[Koha-bugs] [Bug 5373] fields listed on patron import do not match the csv file

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Dec 5 23:00:43 CET 2010


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5373

--- Comment #2 from Garry Collum <gcollum at gmail.com> 2010-12-05 22:00:41 UTC ---
Created attachment 2801
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2801
Proposed Patch

The two columns missing from the list that appear in the example CSV file are
borrowernumber and cardnumber.  The list is generated in import_borrowers.pl,
but there is code that actually removes these two columns from the list.

my $columnkeystpl = [ map { {'key' => $_} }  grep {$_ ne 'borrowernumber' && $_
ne 'cardnumber'} @columnkeys ];  # ref. to array of hashrefs.

This same list is used to create the form which is used to enter the default
values on the Patron Import page.

The proposed patch adds cardnumber to the template page and fixes the loop so
that there is not a dangling comma at the end of the list.

I did not add borrowernumber because it is an auto-incremented value in the
borrower table. Adding a borrowernumber to a CSV file for import does nothing
as far as I can tell.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the Koha-bugs mailing list