[Koha-bugs] [Bug 4224] New: Holds queue report includes items already allocated

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4224

           Summary: Holds queue report includes items already allocated
           Product: Koha
           Version: HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: P5
         Component: Hold requests
        AssignedTo: gmcharlt at gmail.com
        ReportedBy: oleonard at myacpl.org
   Estimated Hours: 0.0
 Change sponsored?: ---


When /misc/cronjobs/holds/build_holds_queue.pl builds the holds queue report,
it looks for items which are available to fulfill an outstanding hold, in
GetItemsAvailableToFillHoldRequestsForBib. It selects items which are
available, not lost etc., and then excludes items ("AND itemnumber NOT IN") in
this set:

SELECT itemnumber
FROM reserves
WHERE biblionumber = ?
AND itemnumber IS NOT NULL
AND (found IS NOT NULL OR priority = 0)

However, look at the data for an item which has been allocated for a hold but
which isn't marked as waiting ("found = W") yet because it is in transit to its
destination branch: reserves.itemnumber will not be NULL, but found *will*
still be NULL. Therefore such items will NOT be excluded from the holds queue
report.

If this diagnosis is correct, that explains why my staff finds entries on the
holds queue report which they have already checked in and sent through cargo
delivery to other branches.

>From IRC today:

<gmcharlt> subquery would then either have to include a join on branchtransfers
<gmcharlt> or perhaps define a new value for found : 'T'
<gmcharlt> meaning that hte item is allocated for a hold but is in transit
---
<gmcharlt> thinking about it a bit more, I think defining a found status of 'T'
is the way to go
<gmcharlt> but there are ~15 place that I'll need to check


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.