[Koha-bugs] [Bug 4045] New: No check for maximum number of allowed holds.

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045

           Summary: No check for maximum number of allowed holds.
           Product: Koha
           Version: HEAD
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: critical
          Priority: P5
         Component: Hold requests
        AssignedTo: henridamien at koha-fr.org
        ReportedBy: oleonard at myacpl.org
   Estimated Hours: 0.0
 Change sponsored?: ---


At some point updatedatabase removed the "maxreserves" system preference:

$dbh->do('DELETE FROM systempreferences WHERE variable = "maxreserves";');

But the opac and staff client still checks for that preference when placing
holds. From request.pl:

    if ( $number_reserves > C4::Context->preference('maxreserves') ) {
        $warnings = 1;
        $maxreserves = 1;
    }

chris fixed this in the OPAC (Bug by allowing holds if maxreserves is not set,
which we could apply to the staff client:

    if ( C4::Context->preference('maxreserves') && $number_reserves >
C4::Context->preference('maxreserves') ) {
        $warnings = 1;
        $maxreserves = 1;
    }

...but that is just bypasses the problem: There is no check of the "Holds
Allowed" value specified in the issuingrules table.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.