[Koha-bugs] [Bug 4451] Batch item tool cannot process barcode file with Windows line endings

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4451

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|henridamien at koha-fr.org     |oleonard at myacpl.org

--- Comment #1 from Owen Leonard <oleonard at myacpl.org>  ---
Some info on IRC from the discussion of Bug 4973:

pianohack > magnus: All chomp does is remove the line ending on the platform
you're running on
pianohack > linux server, windows client?
magnus    > yup
magnus    > adding $command_line =~ s/\r//g; solves it
gmcharlt  > s/\r$//g; would be slightly more precise
pianohack > magnus: You might consider just replacing chomp entirely with
s/[\r\n]*$//g

Guessing this is the cause of this bug as well I looked for chomp in
batchMod.pl:

174            chomp $content;

And changed it based on the pianohack's suggestion:

174            $content = s/[\r\n]*$//g;

This seems to fix the problem.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.