[Koha-bugs] [Bug 4955] adding to basket with no item throws error

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4955

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz>  ---
In this case, it's itemtype that's required, and without a default framework,
the system can't know that it's mandatory. As Nicole said in bug 5073, it's a
bug because of the error message alone. However, when I went into the code,
it's not as simple as I hoped it might be to fix. I think three (and a bit)
possible solutions are:
1) require an ACQ framework to exist, rather than just give a warning. It might
be this could be done in a similar/the same way as in bug 5072. This doesn't
solve the problem of requiring the ACQ to be mandatory however, as if the
framework doesn't require it, (I think) this error will still occur.
1.1) provide a default ACQ framework that is properly set up.
2) Have the code near where the error is happening check for an item type and
display a meaningful error when it's missing.
3) Have some JS on the relevant pages check for itemtype being set and notify
the user.

Possibly all of these are correct, and should be done together :)

The comment on bug 3727 about not setting a default for mandatory items also
has potential, in order to force a decision about what it should be to reduce
the risk of junk entries.

Any thoughts?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.