[Koha-bugs] [Bug 4326] New: Items marked as returned yesterday, even if checked out today

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4326

           Summary: Items marked as returned yesterday, even if checked out
                    today
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P4
         Component: Circulation
        AssignedTo: ian.walls at bywatersolutions.com
        ReportedBy: ian.walls at bywatersolutions.com
   Estimated Hours: 0.0
 Change sponsored?: ---


Items returned today as being marked as returned yesterday, even if DropboxMode
is not set.  This is true even if the item was returned the same day it was
issued (making the return date BEFORE the issue date).

The problem occurs in Circulation.pm, in the AddReserve subroutine.  Code:
------------
if ($doreturn) {
        $borrower or warn "AddReturn without current borrower";
                my $circControlBranch = _GetCircControlBranch($item,$borrower);
        if ($dropbox) {
            # don't allow dropbox mode to create an invalid entry in issues
(issuedate > returndate) FIXME: actually checks eq, not gt
            undef($dropbox) if ( $item->{'issuedate'} eq
C4::Dates->today('iso') );
        }

        if ($borrowernumber) {
            MarkIssueReturned($borrowernumber, $item->{'itemnumber'},
$circControlBranch);
            $messages->{'WasReturned'} = 1;    # FIXME is the "= 1" right? 
This could be the borrower hash.
        }

        ModItem({ onloan => undef }, $issue->{'biblionumber'},
$item->{'itemnumber'});
    }
------------

$circControlBranch should not be defined unless $dropbox is true, and even then
only if issuedate < today.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.