[Koha-bugs] [Bug 4359] New: noItemTypeImages not active in OPAC

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4359

           Summary: noItemTypeImages not active in OPAC
           Product: Koha
           Version: HEAD
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: OPAC
        AssignedTo: oleonard at myacpl.org
        ReportedBy: jwagner at ptfs.com
   Estimated Hours: 0.0
 Change sponsored?: ---


The admin syspref noItemTypeImages appears to have no effect at all in the
OPAC.  If an item type has an image assigned, it will display regardless of
whether the syspref is on or off.  The icons show up in the advanced search
page and on title display pages (and independent of XSLT being on or off).  Is
this by design?  Or should the OPAC be told to obey the syspref?  So far as I
can tell, the syspref does work properly for staff mode.

For advanced search, the problem seems to be in opac-search.pl, in this
segment:

        my %row =(  number=>$cnt++,
                                ccl => $itype_or_itemtype,
                code => $thisitemtype,
                selected => $selected,
                description => $itemtypes->{$thisitemtype}->{'description'},
                count5 => $cnt % 4,
                imageurl=> getitemtypeimagelocation( 'opac',
$itemtypes->{$thisitemtype}->{'imageurl'} ),
            );


The imageurl line should check for the syspref.  Haven't looked at the details
display code yet.

I'm thinking there should be a separate OPACnoItemTypeImages so that staff and
OPAC can be set differently.  Both the advanced search page and the title
display page should obey it.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.