[Koha-bugs] [Bug 4450] Type of error return causes problems

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4450





--- Comment #5 from Chris Nighswonger <cnighswonger at foundations.edu>  2010-05-06 18:51:49 ---
Further thought (ie. I was too quick on the trigger.) has revealed that this
change will cause the error trapping to be rendered useless in the higher level
label/card scripts. That code depends upon the return value being -1 if there
is an error.

Within the context of labels/cards, -1 should never be valid data since all
valid data either consists of an index field or a data structure (ie. hash or
array).

If returning null on db errors is the preferred technique in these cases, then
this patch should also visit all of the error trapping code at higher levels to
port the change there as well. Otherwise we should only address the line of
code which caused the error to be thrown in this case.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.