[Koha-bugs] [Bug 4450] Type of error return causes problems

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4450





--- Comment #11 from Galen Charlton <gmcharlt at gmail.com>  2010-05-07 16:47:08 ---
(In reply to comment #10)
> >Stepping back a bit: how do the callers of those methods *currently* handle
> >errors?  I.e., is the error trapping you're proposing actually in use in some
> >form?
> 
> Examples:
> 
> labels/label-edit-layout.pl - line 144
> labels/label-manage.pl - line 79 (the entire if block)
> patroncards/edit-batch.pl - lines 68-73, 76-80, 87-92,
> patroncards/edit-layout.pl - line 224
> patroncards/edit-template.pl - line 88 (which needs to be changed from 'die' to
> 'warn')
> patroncards/manage.pl - line 78 (the entire if block)
> 
> etc.
> 

But not all of those involve methods that Colin's patch had touched.  For
example, C4::Creators::Batch::remove_items wasn't one of the ones changed - I
think he was just changing methods that, on success, return an object or a data
structure, not those that perform an access and just return an integer with a
success flag.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.