[Koha-bugs] [Bug 4464] Editing a record with a 245a triggers warning about 245 is mandatory

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4464

--- Comment #3 from Jane Wagner <jwagner at ptfs.com>  ---
Some edited discussion from the IRC today about the problem, before Galen sent
his patch.  Including here for background.

<owen> I tried entering a really long title and editing that, but I can't
reproduce your issue
<owen> Is it only in older versions?
<jwagner> The site in production is at roughly .061, but I think my
programmer's test environment is at current head.  I'll doublecheck that with
him.  He reproduced the problem on his dev box.
<owen> jwagner: I did this: open existing record, edit the 245a to make it very
long. Save. Open the record again for editing, save again. 
<gmcharlt> owen: issue probably lies around line 130 of addbiblio.tmpl
<gmcharlt> I was able to reproduce the issue by artificially changing the
threshhold to use textareas instead of inputs to 20
<gmcharlt> that part of the mandatory field check looks for <input> elements,
but ignores textareas
<gmcharlt> whole thng is a candidate for inserting jquery
<gmcharlt> but for now, patching it to also take textareas for subfields into
account is the least disruptive way to change it
<owen> Am I not doing the right thing to trigger the bug?
<jwagner> owen, I just reproduced in my current head system.  The workflow is
importing the bib record (he gets his records from OCLC).  Then open up in Koha
to edit record.  Save it, it triggers the error.
<gmcharlt> in order to trigger the bug, you first have to save or import a
record that has more than 100 characers in the 245 $a
<owen> Long enough to trigger the textarea display, right? I've got that
<gmcharlt> to artificially change the size limit, adjust line 479  of
addbiblio.pl
<jwagner> That was the workaround we were using, I think -- manually changing
the size limit.  Works as an immediate cure but isn't a good long-term fix.
<owen> ...but if all that's necessary to trigger the bug is a 245a textarea,
I've got that. But no warning.
<jwagner> Are you creating or editing the record from scratch in Koha to be
longer than 100 chars?
<jwagner> There may be a difference between importing a record, then editing,
versus creating/editing in Koha.
<owen> Editing an existing record to be longer than 100chars; saving; Editing
again. No warning.
<owen> Hm, a different check for new records?
<jwagner> Let me send you this record & you try to import
* owen can't duplicate the problem even if he imports a new record and tries to
save it with the same long title
<owen> I see, the problem was that my tests used a record with a 245b, and the
check must look for *any* subfield to be filled in (although is it possible to
have a 245b with no 245a?)
<jwagner> Right, the workaround the site developed was to put a space in 245b

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.