[Koha-bugs] [Bug 3777] Field Sizes Inconsistent

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2010-11-25 22:35:33 UTC ---
I am willing to work on this, but need some help deciding about the right data
types.

This lists a lot of fields from the borrowers/deletedborrwoers tables, sorted
and with suggested changes. The line numbers refer to kohastructure.sql in git. 

(http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=9148970ca8a7a44d2846c4c182d05eb460a3df18;hb=HEAD#l250)

SUGGESTION: text?
 199   `surname` mediumtext NOT NULL,
 251   `altcontactsurname` varchar(255) default NULL,
 234   `contactname` mediumtext,

SUGGESTION: text? default null?
 250   `altcontactfirstname` varchar(255) default NULL,
 200   `firstname` text,
 235   `contactfirstname` text,

SUGGESTION: text?
 201   `title` mediumtext,
 236   `contacttitle` text,

 202   `othernames` mediumtext,
 203   `initials` text,

OK - altcontact is missing streetnumber
 204   `streetnumber` varchar(10) default NULL,
 217   `B_streetnumber` varchar(10) default NULL,

OK - altcontact is missing streettype
 205   `streettype` varchar(50) default NULL,
 218   `B_streettype` varchar(50) default NULL,

SUGGESTION: text?
 206   `address` mediumtext NOT NULL,
 219   `B_address` varchar(100) default NULL,
 252   `altcontactaddress1` varchar(255) default NULL,

SUGGESTION: text?
 207   `address2` text,
 220   `B_address2` text default NULL,
 253   `altcontactaddress2` varchar(255) default NULL,

SUGGESTION: text?
 208   `city` mediumtext NOT NULL,
 221   `B_city` mediumtext,
 254   `altcontactaddress3` varchar(255) default NULL,

SUGGESTION: varchar(50)?
 209   `zipcode` varchar(25) default NULL,
 222   `B_zipcode` varchar(25) default NULL,
 255   `altcontactzipcode` varchar(50) default NULL,

SUGGESTION: default null?
 210   `country` text,
 223   `B_country` text,
 256   `altcontactcountry` text default NULL,

SUGGESTION: text? altcontact has no email field.
 211   `email` mediumtext,
 215   `emailpro` text,
 224   `B_email` text,

SUGGESTION: text, default null?
 212   `phone` text,
 216   `phonepro` text,
 213   `mobile` varchar(50) default NULL,
 214   `fax` mediumtext,
 225   `B_phone` mediumtext,
 257   `altcontactphone` varchar(50) default NULL,

SUGGESTION: text, default null?
 238   `borrowernotes` mediumtext,
 246   `opacnote` mediumtext,
 247   `contactnote` varchar(255) default NULL, 
 241   `ethnotes` varchar(255) default NULL,

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.