[Koha-bugs] [Bug 4959] Language inconsistencies on basket groups; skip confirmation when closing basket.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4959

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.walls at bywatersolutions.
                   |                            |com

--- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> 2011-08-03 10:52:13 UTC ---
QA comment

Reading the patch and thinking of ergonomy rules we try to follow in Koha, I
think this patch addresses a problem, but in a wrong way.

Ergonomic rule = don't ask for confirmation if you can cancel the operation.
For example, when you add something, you can delete it after, so don't ask "do
you want to add this". Usually, confirmations are added only for deletions.

So I would say :
* remove the confirmation for reopening the basket, it's useless (you can
always close it again)
* For the close with creating a basket group or no form, it's still needed (as
it's not only a confirmation), so i'm OK with the 
- <label for="createbasketgroup">create a purchase order now?</label>
+ <label for="createbasketgroup">Attach this basket to a new basket group with
the same name</label>

benefit = no syspref added. (I'm strongly against multiplicating sysprefs, we
already have too many !)

IAN = I propose QA failed (but won't set it)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.