[Koha-bugs] [Bug 5436] Extended patron attributes display improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.walls at bywatersolutions.
                   |                            |com, oleonard at myacpl.org

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> 2011-08-03 15:15:49 UTC ---
QA comment

* works as announced. beware the updatedatabase is in an atomicupdate file,
must be added in updatedatabase before applying to master

* there are a few reindenting or minor & unnecessary syntax changes, like: 
-    my ($warning_year, $warning_month, $warning_day) = split /-/,
$borrower->{'dateexpiry'};
-    my (  $enrol_year,   $enrol_month,   $enrol_day) = split /-/,
$borrower->{'dateenrolled'};
+    my ($warning_year, $warning_month, $warning_day) = split (/-/,
$borrower->{'dateexpiry'});
+    my (  $enrol_year,   $enrol_month,   $enrol_day) = split (/-/,
$borrower->{'dateenrolled'});
but nothing worth a failed QA

* there are some properties added to staff-global.css, not sure they are all
relevant (cartmenulink sounds strange. collapseaddress is used & OK). I suggest
asking owen

OWEN = I mark it "passed QA", if you notice something strange on staff-global,
please object

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.