[Koha-bugs] [Bug 5749] The display of borrower adresses composed of streetnumber, streettype and address is broken

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5749

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3138|0                           |1
        is obsolete|                            |

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> 2011-08-04 13:38:40 UTC ---
Created attachment 4843
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4843
proposed patch (updated)

QA comment

* patch 1 contained a reference to .tmpl (removing an empty line). I've
discarded this part of the patch
* if your patron address, uses streetnumber and street type, were not displayed
in result list or in detail before this patch, and are correctly displayed
after. So this patch is OK
* Major problem: It seems that the SetMemberInfosInTemplate sub added in
C4/Members is NOT USED. So it should be removed.
* Minor problem: The address on the left tab still does not contain
streetnumber/type, it could be worth adding it here too

Conclusion :
* Marking Failed QA
* will attach the patch with .tmpl removed
* will affect the bug to Stephane Delaune, that submitted it (but is in holiday
for 3 weeks)

=> Stéphane, please check if SetMemberInfosInTemplate is relevant or no, and
argue or propose another patch.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.