[Koha-bugs] [Bug 6139] Automatic incrementation of call number does not work if given prefix contains a '

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6139

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3831|0                           |1
        is obsolete|                            |

--- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> 2011-08-10 11:56:46 UTC ---
Created attachment 4928
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4928
proposed patch (passed QA)

QA comment

* small patch
* good explanations to reproduce the problem and the fixed behaviour

passed QA earned easily.

Just one note:
-            return => $code,
+            return => $code
=> this change was useless, it's perfectly valid to have something like 
$template->param (xxx => xxx,); in Perl (with a trailing comma at the end)

But is not wrong to have none, so won't refuse passed QA just for this ;-)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.