[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Needs Signoff               |Failed QA

--- Comment #9 from Nicole C. Engard <nengard at gmail.com> 2011-08-24 16:18:01 UTC ---
Notes:

1. White space errors

Applying: Bug 5668 - star ratings in the OPAC
/home/nengard/kohaclone/.git/rebase-apply/patch:210: trailing whitespace.
is 0, then the rating will be deleted. If the value is out of the range of 
/home/nengard/kohaclone/.git/rebase-apply/patch:225: space before tab in
indent.
        carp "Attempted to add a rating for borrower number 0";
/home/nengard/kohaclone/.git/rebase-apply/patch:226: space before tab in
indent.
        return;
/home/nengard/kohaclone/.git/rebase-apply/patch:354: trailing whitespace.

/home/nengard/kohaclone/.git/rebase-apply/patch:358: trailing whitespace.

warning: squelched 63 whitespace errors
warning: 68 lines add whitespace errors.


2. In the sys pref it says "Dont't" - we need to remove the first 't'

3. When you're not logged in you can click on the stars on the search results
and it puts the starts in but says (0 votes) - it shouldn't be clickable if
you're not logged in (like when you're on the detail page)

4. On the detail page it might be nice (not necessary) to say - log in to rate
this title - just like we do for comments and tags.

Marking Failed QA because of #3 which is a misleading problem - but the other
things are here in case they too can be fixed.

I have only tested patch 1 - not the follow up with the delete image.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.