[Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

--- Comment #1 from Ian Walls <ian.walls at bywatersolutions.com> 2011-08-29 16:06:56 UTC ---
Created attachment 5214
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5214
Proposed Patch

AutoLocation should only apply to the staff client login, but when
IndependantBranches was activated, it applied to the OPAC login, as well. 
Login was not prevented, but the patron was greeted with another login prompt,
instead of the My Summary page.  Very confusing.

This patch adds a check for whether this is an OPAC login before executing the
particular code that was causing this.

To test:
1.  Enable IndependantBranches & AutoLocation (be sure your branches have IP
ranges configured!)
2.  Select a staff account, and note the branch
3.  Attempt to login to the staff client from within the IP range for the
branch: this should work
4.  Attempt to login to the staff client from outside the IP range:  this
should be blocked
5.  Attempt to login to the OPAC from within the IP range: this should work
6.  Attempt to login to the OPAC from outside the IP range: this should also
work

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.