[Koha-bugs] [Bug 6132] System preferences are case sensitive

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 2 14:14:44 CET 2011


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6132

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3822|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> 2011-12-02 13:14:44 UTC ---
Created attachment 6529
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6529
New rebased patch

If you call twice C4::Context->preference with the same preference, but with
different case, the sql query will be executed twice and global hash %sysprefs
will have two different keys for the same system preference.
It can causes inconsistencies if syspref is changed between the two calls.
Even if it will happen very rarely, at least this patch doesn't introduce new
problems (as far as we are sure the sql comparison is case insensitive, because
i removed LOWER from the query in this new patch), and it prevents the query to
be executed more than once.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list