[Koha-bugs] [Bug 6699] Add not-empty check for warnings from load_sql in Installer

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6699

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-12-03 11:58:44 UTC ---
(In reply to comment #4)
> patch pushed, with a small follow-up: the fix was hidding the error message,
> but, if there were an SQL error, the error would hare reappeared, as warn $bla
> does not work

Thanks for pushing. No problem with the follow up too. I was only curious if
warn $error would not work. So I tested this:

my $err='a'; warn $err; warn "$err";

With the following result in the logfile:

[Sat Dec 03 12:38:41 2011] [error] [client 82.173.53.17] [Sat Dec  3 12:38:41
2011] opac-main.pl: a at /usr/share/koha/testclone/opac/opac-main.pl line 31.
[Sat Dec 03 12:38:41 2011] [error] [client 82.173.53.17] [Sat Dec  3 12:38:41
2011] opac-main.pl: a at /usr/share/koha/testclone/opac/opac-main.pl line 31.

So I am inclined to think that the followup was not needed, since there is also
a check on $error in the if-condition. But it does not hurt either!

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.