[Koha-bugs] [Bug 6804] If IndependantBranches and AutoLocation enabled, OPAC login does not redirect properly outside IP range

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6804

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Signed Off                  |Failed QA

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-12-05 09:43:16 UTC ---
QA Comment:
I did not test this patch, but have some comments on the code that is not
directly touched by this patch but is in the direct context.

I think that the check if ($ip !~ /^$domain/) does not work. If domain is a
full IP address it works. But if domain is a subnet mask like 199.1.*, the
check will also approve addresses like 199.11.12.13 which it should not (.*
will `eat` 1.12.13).