[Koha-bugs] [Bug 5801] C4::Circulation::_GetCircControlBranch doesn't work in opac-reserve.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5801

Ian Walls <ian.walls at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ian.walls at bywatersolutions.
                   |                            |com

--- Comment #5 from Ian Walls <ian.walls at bywatersolutions.com> 2011-12-05 21:23:49 UTC ---
Just looking at the code, it's pretty clear there are some problems;

_GetCircControlBranch is an internal function (hence the _ at the beginning),
so it shouldn't be called in this script.

Also, as Fridoyln points out, the hashref passed doesn't contain the necessary
information, so results are inaccurate.

And shouldn't we be using ReservesControlBranch, not CircControl and
HomeOrHoldingBranch, to get our rules for a hold?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.