[Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2011-12-07 06:34:15 UTC ---
I tested this but had problems with the date search before and after applying
the patch. 

I added a new subscription with expiration date 'today' and tried searching
with expired before 8/12/2011.

My logs show lots of errors:

[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value $C4::Dates::debug in
numeric gt (>) at /home/katrin/kohaclone/C4/Dates.pm line 170., referer:
http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl
[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value $sqlwhere in concatenation
(.) or string at /home/katrin/kohaclone/C4/Serials.pm line 606., referer:
http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl
[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value in string eq at
/home/katrin/kohaclone/C4/Serials.pm line 615., referer:
http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl
[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value $expirationdate in pattern
match (m//) at /home/katrin/kohaclone/serials/checkexpiration.pl line 81.,
referer: http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl
[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value $expirationdate in pattern
match (m//) at /home/katrin/kohaclone/serials/checkexpiration.pl line 81.,
referer: http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl
[Wed Dec 07 07:28:30 2011] [error] [client 127.0.0.1] [Wed Dec  7 07:28:30
2011] checkexpiration.pl: Use of uninitialized value $C4::Dates::debug in
numeric gt (>) at /home/katrin/kohaclone/C4/Dates.pm line 170., referer:
http://localhost:8080/cgi-bin/koha/serials/checkexpiration.pl

I also tried different settings for the dateformat system preference with the
same result.

Small suggestion for the patch: Perhaps change label to 'Expiring before
today'. Currently it says 'Show items expired before today:' which is a bit
long and 'items' might be a bit confusing.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.