[Koha-bugs] [Bug 7093] Placeholders for suggestion table in suggestion related mails broken

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093

--- Comment #2 from Ian Walls <ian.walls at bywatersolutions.com> 2011-12-07 16:47:14 UTC ---
Created attachment 6639
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6639
Proposed Patch

In parseletter_sth, the suggestions table was defined twice.  The first time
(which is the only definition to get called, as it matches first then exists),
defined the primary search keys as borrowernumber and biblionumber.  This is
incorrect; the only usage of the suggestions table tokens is with suggestionid
as the key.  This is defined further down the if/then chain.

This patch removes the erroneous sth query definition.

To test:

1.  Place a suggestion with a patron account with a configured email you can
access
2.  Approve or reject it
3.  Verify the message you receive contains suggestion tokens (like title,
author and reason)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.