[Koha-bugs] [Bug 7093] Placeholders for suggestion table in suggestion related mails broken

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6639|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2011-12-08 05:46:48 UTC ---
Created attachment 6657
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6657
[SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices

In parseletter_sth, the suggestions table was defined twice.  The first time
(which
is the only definition to get called, as it matches first then exists), defined
the
primary search keys as borrowernumber and biblionumber.  This is incorrect; the
only
usage of the suggestions table tokens is with suggestionid as the key.  This is
defined
further down the if/then chain.

This patch removes the erroneous sth query definition.

To test:

1.  Place a suggestion with a patron account with a configured email you can
access
2.  Approve or reject it
3.  Verify the message you receive contains suggestion tokens (like title,
author and reason)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Suggestion mails for accepted, rejected and ordered look good now.
I couldn't test the suggestion mail AVAILABLE (bug 7096), but
assuming this would work too.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.