[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> 2011-12-14 17:20:37 UTC ---
(In reply to comment #7)
> QA comment : 
> Adrien,
> 
> I think you've found a problem with this syspref !
> 
> But if I push your patch like this, then anyone with an https opac won't have
> rss enabled.
> 
> So, please resubmit a patch with this code removed.
> you can also replace the 
> +    if ( $OPACRssURL !~ m/^http:\/\// ) { $OPACRssURL = "http://" .
> $OPACRssURL }
> 
> by something like
> +    if ( $OPACRssURL !~ m/^http(s?):\/\// ) { $OPACRssURL = "http://" .
> $OPACRssURL }
> 
> I think (untested regexp!)
> 
Hmm what if the site is not served on http:// that will then be a 404 error?

It's a tricky one that is for sure.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.