[Koha-bugs] [Bug 5327] Unit tests required for all C4 modules

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6730|1                           |0
        is obsolete|                            |

--- Comment #69 from Paul Poulain <paul.poulain at biblibre.com> 2011-12-15 15:13:20 UTC ---
Comment on attachment 6730
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6730
[SIGNED-OFF] Bug 5327: Patch removes unneeded self=shift from
TTParser::unshift_token

unobsoleting this patch because I'll revert it

Why did I miss the patch break the tests ? I don't know. But here it is:

prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. 1/2 
#   Failed test 'opac templates are translatable'
#   at xt/author/translatable-templates.t line 54.
# Can't locate object method "type" via package "C4::TTParser" at
TmplTokenizer.pm line 324, <INPUT> line 1.
# 
# tmpl_process3.pl: ERROR: Text extraction failed: ./xgettext.pl: Ioctl()
inappropré pour un périphérique
# 
# tmpl_process3.pl: ERROR: Will not run msgmerge
# 
xt/author/translatable-templates.t .. 2/2 
#   Failed test 'intranet templates are translatable'
#   at xt/author/translatable-templates.t line 54.
# Can't locate object method "type" via package "C4::TTParser" at
TmplTokenizer.pm line 324, <INPUT> line 1.
# 
# tmpl_process3.pl: ERROR: Text extraction failed: ./xgettext.pl: Ioctl()
inappropré pour un périphérique
# 
# tmpl_process3.pl: ERROR: Will not run msgmerge
# 
# Looks like you failed 2 tests of 2.
xt/author/translatable-templates.t .. Dubious, test returned 2 (wstat 512,
0x200)
Failed 2/2 subtests 

Test Summary Report
-------------------
xt/author/translatable-templates.t (Wstat: 512 Tests: 2 Failed: 2)
  Failed tests:  1-2
  Non-zero exit status: 2

after reverting this patch, prove is OK

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.