[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #33 from Paul Poulain <paul.poulain at biblibre.com> 2011-12-16 09:12:32 UTC ---
(In reply to comment #31)
> Just some comments from testing again:
> Patch 2 and 3 need rebasing. If you do, could you squash everything? Will make
> it easier for additional testers.
done

> If the last db rev fails (as in your examples), you allow access to the staff
> client (in standard mode) and you are not going to update page again, I wonder
> if that's what you want. There is a problem and shouldn't it be solved first?
yes, it's what I wanted: if DB rev fails, it's usually because a patch has
already been applied, or your DB structure differ because of some specific
things you've made. It should not prevent you from running Koha. The option
saying "mark as OK" must not be mandatory too, as it means "I know what I did"

So there are 3 options, that will be usefull for debugging if someone faces a
bug:
* patch applied
* patch applied, but failed, and the user did nothing
* patch applied, failed, and the user dealed with it (and has set "mark OK")

> If in dev mode I run the third db rev only WHILE table already EXISTS, I feel
> that the returned message is not so clear. And if I do not mark it as OK and I
> come back at update page, I can still execute it again. Would it not be better
> to mark it as Failed?
> 
> Clicking Home in dev mode still brings me to update page (earlier comment!).
mmm... not sure I understand those lines.

> Since this is a larger change, I do not feel that my tests and [probably] those
> of Chris N really cover all situations. Wouldn't it be better to ask for some
> additional signoffs too?

I would say no: jonathan has tested a lot, it's live at BibLibre customers like
StEtienne (without my follow-up though), i've tested it, chris_n and you too.
That's enough. One can explain for years how to swimm, nothing will replace
jumping in the pool (frenchism suspected... )

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.