[Koha-bugs] [Bug 6323] Attach/move items -- error handling cleanup

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6323

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Patch Status|Signed Off                  |Failed QA

--- Comment #13 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2011-12-19 08:29:41 UTC ---
QA Comment:
You use form method=link in the template. This is not an official method in
html. It should be get or post. I tried to find another example in current Koha
code/template, but it is not present. So I think we should not introduce it,
although it probably works. Links should be <a> tags; you can customize layout
with css.

The action block contains ending tags without opening tags. This may work since
the opening tags could be before the include. But for maintenance, I would
personally not favor it. It would be better if this block is correct on its
own.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.